-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of generic workflows from ACCESS-NRI/access-om2-configs
#24
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 14.44% 14.44%
=======================================
Files 11 11
Lines 547 547
=======================================
Hits 79 79
Misses 468 468 ☔ View full report in Codecov by Sentry. |
…lso added code-style in the issue body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I've added a few minor comments.
I might update the how to run tests manually
part of the readme, to use virtual environments (so to not install to local directory) and to not use payu modules (as its installed as part of model-config-tests). I can create a separate PR for that section, or add a commit to this one?
Co-authored-by: jo-basevi <johanna.basevi@anu.edu.au>
@jo-basevi feel free to commit to this one if it's related :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR moves the deleted workflows from https://github.com/ACCESS-NRI/access-om2-configs/pull/117/files into this repo, references the newly-moved workflows, fixes some bugs, and adds a fresh coat of paint.
In this PR:
pr-*
andschedule-*
workflows from Removal of CI/CD Infrastructure access-om2-configs#117 in 13cd827parse-ci-config
action, also in 13cd827run: gh pr comment ...
commands withuses: access-nri/actions/.github/actions/pr-comment@main
actionsenv:
sectionsgenerate-initial-checksums.yml
->generate-checksums.yml
in b87ed06config-pr-checks.yml
totest-repro.yml
in 9b5645b and removing themodel-name
inputconfig/ci.json
, just in case, in 1d6a172README.md
: new reusable workflowsCI.yml
: Ignore running checks on PRs that modify CI/CD and some other supplementary filesReferences #23