-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up hh5
references, and other logkeeping/documentation fixes
#275
Conversation
…-NRI/access-nri-intake-catalog into 273-remove-hh5-references
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 11 11
Lines 838 838
=======================================
Hits 825 825
Misses 13 13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I've also checked out the branch and grepped for hh5 so I'm confident that you've found every instance
|
||
21/11/2024 | ||
|
||
- Switch to a date-based catalog versioning schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe additionally note catalog version no longer bound to package version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to have to update the changelog for the release anyway, perhaps we make that point there?
@@ -83,28 +93,88 @@ | |||
"name": "stderr", | |||
"output_type": "stream", | |||
"text": [ | |||
"/g/data/hh5/public/apps/miniconda3/envs/analysis3-23.07/lib/python3.10/site-packages/access_nri_intake/source/utils.py:37: UserWarning: Time coordinate does not include bounds information. Guessing start and end times.\n", | |||
"/home/120/mcw120/access-nri/access-nri-intake-catalog/src/access_nri_intake/source/utils.py:113: UserWarning: Time coordinate does not include bounds information. Guessing start and end times.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is potentially the most inane comment I've ever made, but I think we might want to rebuild the docs here after the release so that the warnings point to the right path - not your home dir.
Feel free to merge @marc-white |
Closes #273 .
This PR:
hh5
and theaccess-med
environments;Given @rbeucher will be linking
openmpi
into theconda/analysis3
module load, I've left that out as an explicit requirement at all places, unless the user is going to be catalog building - there it is recommended to be sure (belt & braces).