Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up hh5 references, and other logkeeping/documentation fixes #275

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

marc-white
Copy link
Collaborator

Closes #273 .

This PR:

  • Removes references to hh5 and the access-med environments;
  • Updates the documentation, including the example Jupyter notebooks, to reflect this;
  • Updates the changelog to include versions 0.14 and 0.15. Version 1.0.0 changelog should be done at time-of-release.

Given @rbeucher will be linking openmpi into the conda/analysis3 module load, I've left that out as an explicit requirement at all places, unless the user is going to be catalog building - there it is recommended to be sure (belt & braces).

@marc-white marc-white linked an issue Nov 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (39bea88) to head (12f4b79).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          11       11           
  Lines         838      838           
=======================================
  Hits          825      825           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@charles-turner-1 charles-turner-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I've also checked out the branch and grepped for hh5 so I'm confident that you've found every instance


21/11/2024

- Switch to a date-based catalog versioning schema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe additionally note catalog version no longer bound to package version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to update the changelog for the release anyway, perhaps we make that point there?

@@ -83,28 +93,88 @@
"name": "stderr",
"output_type": "stream",
"text": [
"/g/data/hh5/public/apps/miniconda3/envs/analysis3-23.07/lib/python3.10/site-packages/access_nri_intake/source/utils.py:37: UserWarning: Time coordinate does not include bounds information. Guessing start and end times.\n",
"/home/120/mcw120/access-nri/access-nri-intake-catalog/src/access_nri_intake/source/utils.py:113: UserWarning: Time coordinate does not include bounds information. Guessing start and end times.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially the most inane comment I've ever made, but I think we might want to rebuild the docs here after the release so that the warnings point to the right path - not your home dir.

@rbeucher
Copy link
Member

Feel free to merge @marc-white

@marc-white marc-white merged commit 18b48cd into main Nov 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Remove hh5 references
3 participants