-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skipping tests based on the [SupportedOSPlatform] attribute #48
Conversation
0af73c9
to
ddf4349
Compare
Adding support for `SupportedOSPlatform` is a great because this attributes suppresses the CA1416 code analysis warning. This feature was requested in xunit/xunit#2820 but was not implemented in xUnit.net
ddf4349
to
34c92ae
Compare
e9ad3f8
to
2295987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! Thank you.
Awesome, thanks for merging! Do you plan to release a new (1.5) version on NuGet anytime soon? |
Yes, with your addition I think I'll push the release today. |
I see that version 1.5.22-g0ae9b5ba5c was released. Did you actually mean to publish a prerelease? I read a bit about Nerdbank.GitVersioning, especially Public vs. stable releases and version.json file but I must admit that as a MinVer user I'm a bit lost. 🤨 |
Ah phooey. I meant it to be stable. I changed my release process and apparently there's a bug. I'll get that fixed and re-release. |
I also highly recommend MinVer, though I never tried Nerdbank.GitVersioning, it's very hard to make a mistake with MinVer. |
Oh well. I said what I said. All I can do now is double down on it. |
And I just opened the first pull request ever to use this new feature! 🤓 MarkusPalcer/blurhash.net#28 |
Oh! I hadn't noticed that it works when the |
I documented this behaviour in the private |
Adding support for
SupportedOSPlatform
is great because this attributes suppresses the CA1416 code analysis warning.This feature was requested in xunit/xunit#2820 but was not implemented in xUnit.net
Important
I documented in the README that this feature is available since version 1.5. Please update the README to match the actual version number of the next release.
Ping @sliekens who might be interested in this feature. 😉