Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 2.1.0 #13

Open
Abasz opened this issue Jan 29, 2025 · 0 comments
Open

Breaking changes in 2.1.0 #13

Abasz opened this issue Jan 29, 2025 · 0 comments

Comments

@Abasz
Copy link

Abasz commented Jan 29, 2025

Hi, You changed the Message class by making some of the static methods as non-static. This is a breaking change to the API, yet in your semantic versioning you incremented minor version.

Now these method are only accessible as instance method.... To be honest, this class has no state, so having only static methods made sense. None of the now non-static method access any state so I see no point in changing them.

assignChannel
setDevice
setFrequency
setPeriod
openChannel

You conveniently converted those method to non-static which is not used within web-ant-plus library (e.g. in the example or in the sensors...) and left it un-changed for the rest... Which is also seems to be odd. Can you please explain what was your intention here? More specifically how should the Message class be used now when creating a peripheral (i.e. sensor that broadcasts data)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant