You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, You changed the Message class by making some of the static methods as non-static. This is a breaking change to the API, yet in your semantic versioning you incremented minor version.
Now these method are only accessible as instance method.... To be honest, this class has no state, so having only static methods made sense. None of the now non-static method access any state so I see no point in changing them.
You conveniently converted those method to non-static which is not used within web-ant-plus library (e.g. in the example or in the sensors...) and left it un-changed for the rest... Which is also seems to be odd. Can you please explain what was your intention here? More specifically how should the Message class be used now when creating a peripheral (i.e. sensor that broadcasts data)?
The text was updated successfully, but these errors were encountered:
Hi, You changed the Message class by making some of the static methods as non-static. This is a breaking change to the API, yet in your semantic versioning you incremented minor version.
Now these method are only accessible as instance method.... To be honest, this class has no state, so having only static methods made sense. None of the now non-static method access any state so I see no point in changing them.
You conveniently converted those method to non-static which is not used within web-ant-plus library (e.g. in the example or in the sensors...) and left it un-changed for the rest... Which is also seems to be odd. Can you please explain what was your intention here? More specifically how should the Message class be used now when creating a peripheral (i.e. sensor that broadcasts data)?
The text was updated successfully, but these errors were encountered: