Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opening Header Menu shouldn't add Active Header Cell #1102

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Jan 20, 2025

  • we should add the CSS class slick-column-header-active to the Header Cell only when we start dragging that header, otherwise we shouldn't and that wasn't the case before which showed a the active header and a flickering especially in Dark Mode

brave_VMzYmMpRr8

@ghiscoding ghiscoding merged commit 4ad285b into master Jan 21, 2025
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/header-menu-active-column-header branch January 21, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant