Skip to content

Commit

Permalink
fix(common): cell range decorator should be hidden after onDragEnd (#924
Browse files Browse the repository at this point in the history
)

- issue was found when user has an Editor open and then click on a row checkbox and start dragging that row checkbox cell, then the cell range decorator appears but never goes away because checkbox plugin has prevents event bubbling when having an editor and in turns wasn't destroying the cell range decorator when it should, the cell range decorator isn't visible but it has a z-index of 9999 and even though it's invisible it was showing on top of everything else making the cell behind it unclickable for the size of the cell range decorator (usually about the size of 2-3 cells)
  • Loading branch information
ghiscoding authored Nov 23, 2023
1 parent 012b74c commit b6d02cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/plugins/slick.cellrangeselector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ export class SlickCellRangeSelector implements SlickPlugin {
}

protected handleDragEnd(e: Event, dd: DragPosition) {
this._decorator.hide();
if (!this._dragging) {
return;
}
Expand All @@ -373,7 +374,6 @@ export class SlickCellRangeSelector implements SlickPlugin {
e.stopImmediatePropagation();

this.stopIntervalTimer();
this._decorator.hide();
this.onCellRangeSelected.notify({
range: new SlickRange(
dd.range.start.row ?? 0,
Expand Down

0 comments on commit b6d02cd

Please sign in to comment.