Fix various incompatible pointer types. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bunch of type errors like the following, by casting the expected types, working around gcc warnings that have gone fatal in gcc 14: src/index.c:1263:59: error: passing argument 2 of ‘ti_querys_2d_multi’ from incompatible pointer type +[-Wincompatible-pointer-types] 1263 | sequential_iter_t *siter = ti_querys_2d_multi(t, regions, n_sub_list); | ^~~~~~~ | | | char ** src/pairix.h:131:73: note: expected ‘const char **’ but argument is of type ‘char **’ Note the pointer returned by ti_iter_first cast to "int" in function ti_query_2d_tid, in src/index.c, feels like an incident waiting to happen, but the function is expected to return addresses or error codes, so it is left as-is due to lack of better idea for the moment. Signed-off-by: Étienne Mollier <emollier@debian.org>
|
can confirm this solution works for me @clarabakker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bunch of type errors like the following, by casting the expected types, working around gcc warnings that have gone fatal in gcc 14:
Note the pointer returned by ti_iter_first cast to "int" in function ti_query_2d_tid, in src/index.c, feels like an incident waiting to happen, but the function is expected to return addresses or error codes, so it is left as-is due to lack of better idea for the moment.