Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hhh 118 update interpolation method in waverespons as todays method is deprecated #65

Merged
merged 15 commits into from
Jul 4, 2024
Merged

Hhh 118 update interpolation method in waverespons as todays method is deprecated #65

merged 15 commits into from
Jul 4, 2024

Conversation

helene-pisani-4ss
Copy link
Contributor

@helene-pisani-4ss helene-pisani-4ss commented Jul 1, 2024 •
edited by jira bot
Loading

This PR is related to user story HHH-118

Description

update interpolation method in waverespons as todays method is deprecated. from interp2d to RegularGridInterpolator.

Checklist

  • [x ] PR title is descriptive and fit for injection into release notes (see tips below)
  • [ x] Correct label(s) are used

PR title tips:

  • Use imperative mood
  • Describe the motivation for change, issue that has been solved or what has been improved - not how
  • Examples:
    • Add functionality for Allan variance to sensor_4s.simulate
    • Upgrade to support Python 9.10
    • Remove MacOS from CI

vegard-solum-4ss
vegard-solum-4ss previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@vegard-solum-4ss vegard-solum-4ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But remove the pinning of scipy in pyproject.toml.

(I suggest we remove the pinning of numpy as well. Not sure why is was pinned in the first place?)

@helene-pisani-4ss helene-pisani-4ss merged commit f45955b into main Jul 4, 2024
6 checks passed
@helene-pisani-4ss helene-pisani-4ss deleted the HHH-118-Update-interpolation-method-in-waverespons-as-todays-method-is-deprecated branch July 4, 2024 11:23
@heidi-holm-4ss heidi-holm-4ss added the enhancement Changes that make the code perform better label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegard-solum-4ss vegard-solum-4ss vegard-solum-4ss approved these changes

@heidi-holm-4ss heidi-holm-4ss Awaiting requested review from heidi-holm-4ss

Assignees
No one assigned
Labels
enhancement Changes that make the code perform better
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helene-pisani-4ss @vegard-solum-4ss @heidi-holm-4ss