Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin numpy version and update python version #49

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Pin numpy version and update python version #49

merged 10 commits into from
Jan 25, 2024

Conversation

hanne-opseth-rygg-4ss
Copy link
Contributor

@hanne-opseth-rygg-4ss hanne-opseth-rygg-4ss commented Jan 24, 2024 •
edited
Loading

This PR is related to user story ESS-2278

Description

  • Update python version
  • Lock numpy version
  • Fix deprecated functionality (H->h, line_terminator -> lineterminator, handle concatenating empty data frames)

Checklist

  • All COS are met.
  • All integration tests pass (if applicable).
  • New functions, methods and classes are added to the documentation.
  • New functions, methods and classes are tested (hint: check coverage report).

@hanne-opseth-rygg-4ss hanne-opseth-rygg-4ss changed the title Update version python Pin numpy version and update python version Jan 25, 2024
branislav-jenco-4ss
branislav-jenco-4ss previously approved these changes Jan 25, 2024
View reviewed changes
Copy link

@branislav-jenco-4ss branislav-jenco-4ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hanne-opseth-rygg-4ss hanne-opseth-rygg-4ss merged commit 2e5edba into main Jan 25, 2024
9 checks passed
@hanne-opseth-rygg-4ss hanne-opseth-rygg-4ss deleted the update_version_python branch January 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heidi-holm-4ss heidi-holm-4ss heidi-holm-4ss approved these changes

@branislav-jenco-4ss branislav-jenco-4ss Awaiting requested review from branislav-jenco-4ss

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanne-opseth-rygg-4ss @heidi-holm-4ss @branislav-jenco-4ss