Ess-3110 Not all fields are mapped when getting a campaign #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n gracefully if no operations
|
We have to fix
|
I snuck in and fixed the style by running |
| @@ -278,6 +287,15 @@ def test_get_campaign_camelcase( | |||
| "Main Data Provider": "4Subsea", | |||
| "Start Date": "2017-04-08T00:00:00+00:00", | |||
| "End Date": "2017-05-13T00:00:00+00:00", | |||
| "GeoTrack Location": "10#21", | |||
There was a problem hiding this comment.
I don't know why it needs all these, I assume they have been added to the API without the package having been built and therefore we do not pick up errors in integration tests. Perhaps we should run these tests when we deploy 4insight, or at least at some intervals to stay up to date on changes...
pamela-joslyn-4ss
requested review from
bjorn-einar-bjartnes-4ss and
hakon-molven-4ss
bjorn-einar-bjartnes-4ss
approved these changes
Nov 25, 2024
bjorn-einar-bjartnes-4ss
deleted the
ESS-3110-Not-all-fields-are-mapped-when-getting-a-campaign
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to user story https://4insight.atlassian.net/browse/ESS-3110) and https://4insight.atlassian.net/browse/ESS-3038
Description
Map all fields on get_campaign
Also fixed bug ESS_3038 get_swimops_campaign does not return gracefully if no operations
Checklist