get_sensors now return serial number #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanne-opseth-rygg-4ss
requested review from
bjorn-einar-bjartnes-4ss and
heidi-holm-4ss
heidi-holm-4ss
approved these changes
Oct 30, 2023
heidi-holm-4ss
changed the title
bjorn-einar-bjartnes-4ss
approved these changes
Oct 30, 2023
|
Looks good, took a while to review because I wasn't sure how to run it locally with tests and all (got it running with tox -e py). I just wanted to see that the tests broke as expected when not including your changes as well. Makes more sense imo to do it this way, with requiring a certain set of data to be there, but not fail if more is added to the API. |
hanne-opseth-rygg-4ss
deleted the
ESS-1982-get-sensors-should-return-serial-number
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to user story ESS-1982
Get sensors now return serial number.