Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add scroll option support for React SPA adapter #911

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat: Add scroll option support for React SPA adapter #911

merged 3 commits into from
Feb 13, 2025

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Feb 12, 2025 •
edited
Loading

Adding a test for #912 surfaced that the scroll option wasn't implemented for the React SPA adapter.

Tasks

  • Figure out why Next.js pages router tests fail in CI but pass locally (and actually should pass in CI since the screenshot looks correct) 🤷 -> M4x is too fast, had to increase timeouts.

Closes #912.

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 9:10am

@franky47 franky47 marked this pull request as draft February 12, 2025 22:42
@franky47 franky47 added this to the 🪵 Backlog milestone Feb 12, 2025
@franky47 franky47 mentioned this pull request Feb 12, 2025
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 12, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/nuqs@911

commit: 152fb86

@franky47 franky47 added the adapters/react Uses the React SPA adapter label Feb 12, 2025
@franky47 franky47 marked this pull request as ready for review February 13, 2025 09:17
@franky47 franky47 changed the title fix: Scroll feat: Add scroll option support for React SPA adapter Feb 13, 2025
@franky47 franky47 merged commit 223609e into next Feb 13, 2025
27 checks passed
@franky47 franky47 deleted the fix/906-scroll branch February 13, 2025 09:19
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.4.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@franky47 franky47 removed this from the 🚀 Shipping next milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
adapters/react Uses the React SPA adapter released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting scroll: false with React Router v6 does not work as intended
1 participant
@franky47