kmin 계산기 제출입니다. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyo-choi
reviewed
Jun 28, 2021
Comment on lines
+3
to
+6
| "env": { | ||
| "TOTAL": "#total", | ||
| "MODIFIER": ".modifier" | ||
| } |
There was a problem hiding this comment.
Cypress에서도 환경변수를 넘겨줄 수 있었네요! 하나 배워갑니다.
Comment on lines
+15
to
+16
| this.$element.addEventListener('click', ({target}) => { | ||
| if (!(target instanceof HTMLButtonElement)) return; |
There was a problem hiding this comment.
저도 event에서 target을 바로 따오려고 하다가 잘 안 돼서 결국 다른 방법을 사용했는데, 이 코드를 보고 어떻게 하면 좋은지 딱 깨달은 것 같아요. 하나 더 배워갑니다! ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 규칙에 맞춰서 커밋을 작성하지 못했습니다. 죄송합니다...
데모 : https://kmin-283.github.io/javascript-calculator/