Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable video specs #13

Merged
merged 2 commits into from
Dec 13, 2024
Merged

configurable video specs #13

merged 2 commits into from
Dec 13, 2024

Conversation

cyKkk0
Copy link
Collaborator

@cyKkk0 cyKkk0 commented Dec 12, 2024

In config.go
add a struct called ImageSpecifications to cover the video specs: ImgWidth, ImgHeight, FrameRate, their types are int, int, float64

accordingly, in main.go
transfer the pointer to ImageSpecifications to initialize the peerconnection

in ...adapter.go
add properties to adapter,:width, height, framerate
note that, in func Properties prop.video.FrameRate should be float32 type, in this func,I turn the float64 to float32 by force. float32(FrameRate)

in config.go
we check the width, height, framerate should bigger than 0, but I still check that in sender/peerconnection.go, by assigning default value, 640, 480 and 30.00

@cyKkk0 cyKkk0 changed the title configurable vIE哦 configurable video specs Dec 12, 2024
@cyKkk0 cyKkk0 requested a review from 3DRX December 12, 2024 14:21
@3DRX
Copy link
Owner

3DRX commented Dec 13, 2024

LGTM!

@3DRX 3DRX merged commit 4743a04 into main Dec 13, 2024
1 check passed
Copy link
Owner

@3DRX 3DRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@3DRX 3DRX deleted the tmp branch December 13, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants