Proxy exec #1310
Merged
Proxy exec #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
libangzhu
commented
Sep 11, 2023
libangzhu
commented
- 增加交易代理执行逻辑
- 调整wallet 模块针对0x地址签名适配的问题
- 在mempool 中检查nonce 问题
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
==========================================
+ Coverage 62.00% 62.04% +0.04%
==========================================
Files 171 171
Lines 23752 23788 +36
==========================================
+ Hits 14727 14760 +33
- Misses 7187 7189 +2
- Partials 1838 1839 +1
☔ View full report in Codecov by Sentry. |
bysomeone
reviewed
Sep 13, 2023
Comment on lines
+602
to
+637
| func (e *executor) proxyGetRealTx(tx *types.Transaction) (*types.Transaction, error) { | ||
| if string(types.GetRealExecName(tx.GetExecer())) != "evm" { | ||
| return nil, fmt.Errorf("execName %s not allowd", string(types.GetRealExecName(tx.GetExecer()))) | ||
| } | ||
| var actionData types.EVMContractAction4Chain33 | ||
| err := types.Decode(tx.GetPayload(), &actionData) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if len(actionData.GetPara()) == 0 { | ||
| return nil, errors.New("empty tx") | ||
| } | ||
| var realTx types.Transaction | ||
| err = types.Decode(actionData.Para, &realTx) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &realTx, nil | ||
|
|
||
| } | ||
|
|
||
| func (e *executor) proxyExecTx(tx *types.Transaction) (*types.Transaction, error) { | ||
| var realTx = tx | ||
| var err error | ||
| if tx.To == e.cfg.GetModuleConfig().Exec.ProxyExecAddress { | ||
| realTx, err = e.proxyGetRealTx(tx) | ||
| if err != nil { | ||
| return realTx, err | ||
| } | ||
| realTx.Signature = tx.Signature | ||
|
|
||
| } | ||
| return realTx, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
ok
plugin 也会增加ci 集成测试
bysomeone
approved these changes
Sep 15, 2023
|
🎉 This PR is included in version 1.68.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.