Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of hosts not alphabetized after upgrade to High Sierra #140

Open
jaygerland opened this issue Mar 9, 2018 · 4 comments
Open

List of hosts not alphabetized after upgrade to High Sierra #140

jaygerland opened this issue Mar 9, 2018 · 4 comments

Comments

@jaygerland
Copy link

SSIA, after upgrading to High Sierra, everything works great but the drop down list and the list in the editor are no longer sorted alphabetically. Would be great to have them sorted again. Thanks for the great app, could not live without it.
@jaygerland
Copy link
Author

Full disclosure, I went from El Capitan to High Sierra (skipped Sierra).

@paulurbano
Copy link

I saw this too after I upgraded from Sierra to High Sierra

@riaan
Copy link

riaan commented Jun 26, 2018 •
edited
Loading

Same here, would be nice if the list is sorted again (30+ local and 30+ combined hosts in my dropdown)

Edit: Might be an APFS issue, on HFS+ the list is sorted alphabetic

@amityweb
Copy link

amityweb commented Oct 3, 2018

Sorry for more plus 1's but perhaps good to express annoyance.

Its a strange issue. If you view them in Finder, sorting by name, or any date (created, added, modified) does not match the ordering in Gas Mask. So I have no idea what ordering its taking, as its not alphabetical, or to do with the original date added?

If I add a new one it goes to the bottom, but if I restart Gas Mask its in the middle of the list.

rstad added a commit to rstad/gasmask that referenced this issue Jan 23, 2019
@rstad
Sort Local hosts when loading
745bce2 
As mentioned in Issues 2ndalpha#160 and 2ndalpha#140, the list of hosts is not
alphabetized in newer versions of macOS. This change is a feeble
attempt by me to sort the `hostsFiles` array as it's populated.

It seems to have built successfully on my machine but I'm
extremely new to the world of Obj-C development so it would not
surprise me in the least if this does something in a bad or
easily improved way.

That is, I added a way to Sort (`NSSortDescriptor`) and call it
immediately after every time we `addObject` to `hostsFiles` during
`loadFiles` in LocalHostsController.m.

Doing this after every addition seems like it might be a poor
choice from a performance perspective.  Moreover, it may be
wholly unnecessary when used in some environments where this issue
doesn't present.  I went with it anyway because I didn't know how
else to approach this, nor how to conditionally use this logic
only when I know it to be necessary.
@rstad rstad mentioned this issue Jan 23, 2019
Open
@mkormendy mkormendy mentioned this issue Nov 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@riaan @jaygerland @amityweb @paulurbano