Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc does not support websocket. #74

Merged
merged 3 commits into from
Jun 13, 2024
Merged

rc does not support websocket. #74

merged 3 commits into from
Jun 13, 2024

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Jun 13, 2024

SSIA.

@k1LoW k1LoW self-assigned this Jun 13, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@k1LoW k1LoW force-pushed the not-support-websocket branch from 537df3f to 3419f33 Compare June 13, 2024 02:53
@k1LoW k1LoW requested review from pyama86 and Drumato June 13, 2024 02:54
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
pyama86
pyama86 reviewed Jun 13, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
80.3% 1:2.3 38s

Code coverage of files in pull request scope (71.4%)

Files Coverage
rc.go 73.5%
testutil/http.go 64.3%

Reported by octocov

@k1LoW k1LoW merged commit 0c5113c into main Jun 13, 2024
3 checks passed
@k1LoW k1LoW deleted the not-support-websocket branch June 13, 2024 03:03
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyama86 pyama86 pyama86 approved these changes

@Drumato Drumato Awaiting requested review from Drumato

Assignees

@k1LoW k1LoW

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k1LoW @pyama86