Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not store responses with Set-Cookie headers by default, similar to NGINX #39

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Dec 20, 2023

In RFC 9111, Servers that wish to control caching of responses with Set-Cookie headers are encouraged to emit appropriate Cache-Control response header fields (see https://httpwg.org/specs/rfc9111.html#rfc.section.7.3).
But to beat on the safe side, this package does not store responses with Set-Cookie headers by default, similar to NGINX.
THIS IS NOT RFC 9111.

@k1LoW k1LoW self-assigned this Dec 20, 2023
@k1LoW k1LoW force-pushed the ignore-set-cookie branch from 0951b82 to c738736 Compare December 20, 2023 05:29

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (45b3316) #39 (969fe46) +/-
Coverage 80.9% 80.3% -0.7%
Code to Test Ratio 1:2.0 1:2.0 -0.0
Test Execution Time 32s 38s +6s
Details
  |                     | main (45b3316) | #39 (969fe46) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          80.9% |         80.3% | -0.7% |
  |   Files             |              4 |             4 |     0 |
  |   Lines             |            299 |           304 |    +5 |
+ |   Covered           |            242 |           244 |    +2 |
- | Code to Test Ratio  |          1:2.0 |         1:2.0 |  -0.0 |
  |   Code              |            660 |           670 |   +10 |
+ |   Test              |           1324 |          1342 |   +18 |
- | Test Execution Time |            32s |           38s |   +6s |

Code coverage of files in pull request scope (87.3% → 85.8%)

Files Coverage +/-
rfc9111/shared.go 85.8% -1.5%

Reported by octocov

@k1LoW k1LoW merged commit 337bbda into main Dec 20, 2023
3 checks passed
@k1LoW k1LoW deleted the ignore-set-cookie branch December 20, 2023 05:31
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant