Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Endpoint #651

Closed
Mirko-von-Leipzig opened this issue Jan 28, 2025 · 1 comment
Closed

Remove Endpoint #651

Mirko-von-Leipzig opened this issue Jan 28, 2025 · 1 comment
Labels
good first issue Good for newcomers
Milestone
v0.8

Comments

@Mirko-von-Leipzig
Copy link
Contributor

This type is a leaky abstraction. The http/url specification is long and many parts are optional.

I propose removing the type entirely, and letting our http server/client frameworks deal with parsing whatever configuration was provided. aka just use String or equivalent until it hits the library we use.

Briefly discussed in #647.
@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this issue Jan 28, 2025
Merged
@bobbinth bobbinth added the good first issue Good for newcomers label Jan 28, 2025
@bobbinth bobbinth added this to the v0.8 milestone Jan 28, 2025
@sergerad sergerad mentioned this issue Jan 29, 2025
Merged
@bobbinth
Copy link
Contributor

Closed by #654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
2 participants
@bobbinth @Mirko-von-Leipzig