Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement player handles #117

Open
norswap opened this issue Feb 14, 2024 · 13 comments
Open

Implement player handles #117

norswap opened this issue Feb 14, 2024 · 13 comments

Comments

@norswap
Copy link
Member

norswap commented Feb 14, 2024

Two key features:

  • resolve players ENS if they have one, use https://viem.sh/docs/ens/actions/getEnsName.html

  • Add a PlayerHandle contract where users can register a single handle for their address (they should be able to change it as well)

    • Handles should be unique
    • Add a checkHandleValidity function that restricts names (e.g. only ASCII, minimum 5 characters, maybe not contain dots (to avoid ENS / other name system clashes)
    • Add a checkPlayerEligibility that can be always true for now but down the line will only enable players that have completed some milestones (e.g. minimum amount of matches, minimum spend, ...) to register handles to avoid squatting.
    • If a user has an ENS, let them select whether they want to use their handle or their ENS.
    • Add an admin role that can be used later to avoid impersonation and squatting of popular names.

The frontend must be modified to display player handles (or ENS).

@faytey
Copy link
Contributor

faytey commented Feb 15, 2024

can i hop on this?

@norswap
Copy link
Member Author

norswap commented Feb 15, 2024

Go ham :)

@faytey
Copy link
Contributor

faytey commented Feb 19, 2024

Thanks I'd work on this, for better context, I'd be writing a cairo contract to handle Player Ens/profile and updating the frontend showing their ens right?

@norswap
Copy link
Member Author

norswap commented Feb 21, 2024

No, we're using Solidity on this game as we target an EVM rollup chain. Cairo contracts only work on Starknet.

@saimeunt
Copy link

@faytey have you started working on this?
I'd like to take this one if you change your mind and work on something else please.

@faytey
Copy link
Contributor

faytey commented Feb 22, 2024

Just seeing this notification @saimeunt yes you can go ahead. @norswap I’d take up other issues thanks

@faytey
Copy link
Contributor

faytey commented May 2, 2024

If this issue is still up, i would love to continue working on it @norswap

@saimeunt
Copy link

saimeunt commented May 2, 2024

Hey I'm no longer actively working on this feel free to pick it @faytey

@faytey
Copy link
Contributor

faytey commented May 2, 2024

Hey I'm no longer actively working on this feel free to pick it @faytey

Cool, @norswap is this okay?

@norswap
Copy link
Member Author

norswap commented May 2, 2024

Yes, go for it!

@faytey faytey mentioned this issue May 20, 2024
4 tasks
@faytey
Copy link
Contributor

faytey commented May 20, 2024

Hi Sir @norswap I made a PR to this issue here 117 I need your review and comments sir.

@faytey
Copy link
Contributor

faytey commented May 21, 2024

@norswap

Hi Sir @norswap I made a PR to this issue here 117 I need your review and comments sir.

@norswap
Copy link
Member Author

norswap commented May 30, 2024

Sorry, things have been hectic these days. I will try to review this as soon as possible, but it might still take a few days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants