Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode in about us page and services page #242

Merged
merged 6 commits into from
Oct 27, 2024

Conversation

Deepika14145
Copy link
Contributor

@Deepika14145 Deepika14145 commented Oct 6, 2024

🚀 Pull Request

Description

closes #211

Please include a summary of the changes and the related issue. Provide relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

  • [+] New feature (non-breaking change which adds functionality)
  • added dark mode in about us page and services page

Checklist:

  • [+] My code follows the style guidelines of this project
  • [+] I have performed a self-review of my own code
  • [+] I have commented my code, particularly in hard-to-understand areas
  • [+] I have made corresponding changes to the documentation
  • [+] My changes generate no new warnings
  • [+] I have added tests that prove my fix is effective or that my feature works
  • [+] New and existing unit tests pass locally with my changes
  • [+] Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

about us page -
Screenshot 2024-10-06 163103
services page -
Screenshot 2024-10-06 163218

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@Deepika14145
Copy link
Contributor Author

Please review @sanjay-kv

about.html Outdated Show resolved Hide resolved
about.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@akbatra567 akbatra567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some common styles related to dark mode theme which is added to both about.html and serv.html and would be similar for other pages. Could you create an external css file and transfer the common css there and import that and verify if it works the same.

@Deepika14145
Copy link
Contributor Author

I will check all above mentioned issues and will work on ìt.

@Deepika14145
Copy link
Contributor Author

Sorry for late actually my exams are going on I will update it soon @akbatra567

Now the changes are made
Updated file
Could you check now? It quite matches with the CSS of other pages.
@Deepika14145
Copy link
Contributor Author

Can you please review the changes that I have made @akbatra567 ? I have committed some changes.

@Deepika14145
Copy link
Contributor Author

Hello, @akbatra567 Please review the changes I have made in PR.

@akbatra567
Copy link
Collaborator

Hello, @akbatra567 Please review the changes I have made in PR.

Requested changes are missing:

I see some common styles related to dark mode theme which is added to both about.html and serv.html and would be similar for other pages. Could you create an external css file and transfer the common css there and import that and verify if it works the same.

Let me explain this a bit on what you need to do:

  1. See what all common styles you are using for the 2 html pages.
  2. create a common css file name could be anything you feel adds more value, suggestions: dark.css - in case you only copy dark theme styles, else could be main.css / common.css
  3. Import this newly created css file inside the html files replacing the duplicated code from the files. using <link rel="stylesheet" href='<add file path here>'>
  4. Verify the styles if it working as expected.
  5. Tag me when you complete these.

@Deepika14145
Copy link
Contributor Author

ok @akbatra567 i will update it soon

@07sumit1002 07sumit1002 merged commit d67fb61 into 07sumit1002:main Oct 27, 2024
2 of 3 checks passed
@Deepika14145
Copy link
Contributor Author

If this PR is merged then why its not showing "Accepted" on hacktoberbest website @07sumit1002

@Deepika14145
Copy link
Contributor Author

please add hacktoberfest-accepted labels to this PR @07sumit1002 and labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Dark mode to other pages(About, service) since its applied to only Home page.
3 participants