-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dark mode in about us page and services page #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
Please review @sanjay-kv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some common styles related to dark mode theme which is added to both about.html
and serv.html
and would be similar for other pages. Could you create an external css file and transfer the common css there and import that and verify if it works the same.
I will check all above mentioned issues and will work on ìt. |
Sorry for late actually my exams are going on I will update it soon @akbatra567 |
Now the changes are made
Updated file
Could you check now? It quite matches with the CSS of other pages.
Can you please review the changes that I have made @akbatra567 ? I have committed some changes. |
Hello, @akbatra567 Please review the changes I have made in PR. |
Requested changes are missing:
Let me explain this a bit on what you need to do:
|
ok @akbatra567 i will update it soon |
If this PR is merged then why its not showing "Accepted" on hacktoberbest website @07sumit1002 |
please add hacktoberfest-accepted labels to this PR @07sumit1002 and labels |
🚀 Pull Request
Description
closes #211
Please include a summary of the changes and the related issue. Provide relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change
Checklist:
Screenshot of final output/video
about us page -
services page -