Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding subject,audit and the env files #2394

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

zanninso
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inline.

Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inline.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@zanninso zanninso requested a review from nprimo January 25, 2024 22:31
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one doubt regarding the suggestion given on line 29 in the subject: I left other comments around the subject and audit, but they're all mainly linked to that.

@zanninso zanninso requested a review from nprimo January 30, 2024 00:26
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zanninso zanninso merged commit b631b2c into master Jan 31, 2024
2 checks passed
@zanninso zanninso deleted the CON-2353-Fixing-Java-branch-for-grit-lab- branch January 31, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants