Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2343: fix numpy readme and audit #2362

Merged
merged 3 commits into from
Mar 21, 2024
Merged

CON-2343: fix numpy readme and audit #2362

merged 3 commits into from
Mar 21, 2024

Conversation

MSilva95
Copy link
Member

No description provided.

@MSilva95 MSilva95 self-assigned this Dec 21, 2023
@MSilva95 MSilva95 requested a review from nprimo December 21, 2023 18:13
nprimo
nprimo reviewed Dec 21, 2023
View reviewed changes
subjects/ai/numpy/README.md Outdated Show resolved Hide resolved
nprimo
nprimo reviewed Dec 21, 2023
View reviewed changes
subjects/ai/numpy/README.md Outdated Show resolved Hide resolved
nprimo
nprimo reviewed Dec 21, 2023
View reviewed changes
subjects/ai/numpy/README.md Outdated Show resolved Hide resolved
nprimo
nprimo reviewed Dec 21, 2023
View reviewed changes
subjects/ai/numpy/README.md Outdated Show resolved Hide resolved
nprimo
nprimo suggested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments in line - there are some points that don't match between subject/audit/solutions.

nprimo
nprimo approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

nprimo
nprimo reviewed Feb 5, 2024
View reviewed changes
subjects/ai/numpy/README.md Outdated Show resolved Hide resolved
@MSilva95 MSilva95 merged commit bf52602 into master Mar 21, 2024
2 checks passed
@MSilva95 MSilva95 deleted the CON-2343-review-and-fix-numpy branch March 21, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nprimo nprimo nprimo approved these changes

Assignees

@MSilva95 MSilva95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSilva95 @nprimo