Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nlp-spacy subject Exercise 3 audit specifies extra task #2346

Closed
jarmo-seljamaa opened this issue Dec 7, 2023 · 3 comments · Fixed by #2351
Closed

nlp-spacy subject Exercise 3 audit specifies extra task #2346

jarmo-seljamaa opened this issue Dec 7, 2023 · 3 comments · Fixed by #2351
Assignees

Comments

@jarmo-seljamaa
Copy link

nlp-spacy

Audit question for Exercise 3 includes two parts. The first (shape of the embeddings of each word) is included in the task, but the second (the first 20 values of the embedding of laptop) is not specified in task description.

@nprimo nprimo self-assigned this Dec 11, 2023
@nprimo
Copy link
Contributor

nprimo commented Dec 11, 2023

Hi @jarmo-seljamaa, thank you for the feedback.

If you have calculated the embeddings of each word, you should be able to verify the first 20 values of the embedding related to laptop word :)

The audit is not a machine test therefore, you should be able to show the results to the person that is going to audit you.
In any case, I am reviewing the exercise to add the version of the language model to use to avoid mismatches in the values

@nprimo nprimo linked a pull request Dec 11, 2023 that will close this issue
@jarmo-seljamaa
Copy link
Author

Hi @nprimo, thank you for the response.

I reported this because in 01 program so far the audit questions verify the task results and the required output (in this case printing out 20 values of the embedding) is usually already included in the task description. This makes the auditing process also much smoother, because you have all the elements for audit already present in the code.

It has been rather strange to solve tasks in this branch with always keeping the audit questions at the side, because there is no other way of knowing what will be actually checked in the audit. I believe this branch deviates in that sense from the rest of 01 program.

@nprimo
Copy link
Contributor

nprimo commented Dec 12, 2023

Hi @jarmo-seljamaa thank you for sharing with us your opinion 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants